CU-2p64ar7 - Update custom rpc wrapper representation #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: CU-2p64ar7 Asset RPC balanceOf |
hussein-aitlahcen
force-pushed
the
rpc-assets-balanceof
branch
from
99dfbe5
to
a8da496
Compare
Codecov Report
@@ Coverage Diff @@
## main #900 +/- ##
==========================================
+ Coverage 70.76% 70.82% +0.06%
==========================================
Files 215 215
Lines 31106 31078 -28
==========================================
Hits 22012 22012
+ Misses 9094 9066 -28
Continue to review full report at Codecov.
|
dzmitry-lahoda
approved these changes
Apr 19, 2022
andor0
approved these changes
Apr 19, 2022
vimukthi-git
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fix the
assets.balanceOfcustom RPC by moving the expected JSON representation from hex string to string (Display).Checklist
book/to reflect changes made by this PR (if applicable)